Skip to content

[v2] add initial Command Buffers support#2629

Merged
pbalcer merged 5 commits into
oneapi-src:mainfrom
pbalcer:add-command-buffer-support
Jan 29, 2025
Merged

[v2] add initial Command Buffers support#2629
pbalcer merged 5 commits into
oneapi-src:mainfrom
pbalcer:add-command-buffer-support

Conversation

@pbalcer
Copy link
Copy Markdown
Contributor

@pbalcer pbalcer commented Jan 28, 2025

No description provided.

@pbalcer pbalcer requested review from a team as code owners January 28, 2025 12:40
@pbalcer pbalcer requested a review from Bensuo January 28, 2025 12:40
@pbalcer
Copy link
Copy Markdown
Contributor Author

pbalcer commented Jan 28, 2025

This is a rebased and cleaned up version of #2532. I didn't want to force push to that PR to preserve the old history on that branch.

@github-actions github-actions Bot added level-zero L0 adapter specific issues command-buffer Command Buffer feature addition/changes/specification labels Jan 28, 2025
Bensuo
Bensuo reviewed Jan 28, 2025
View reviewed changes
Comment thread source/adapters/level_zero/v2/command_buffer.cpp Outdated
Comment thread source/adapters/level_zero/v2/command_list_manager.hpp Outdated
Comment thread source/adapters/level_zero/v2/command_list_manager.cpp Outdated
Comment thread source/adapters/level_zero/v2/command_list_manager.hpp Outdated
Comment thread source/adapters/level_zero/v2/command_buffer.hpp Outdated
@EwanC EwanC self-requested a review January 28, 2025 13:58
EwanC
EwanC reviewed Jan 28, 2025
View reviewed changes
Comment thread source/adapters/level_zero/v2/command_buffer.cpp Outdated
Comment thread source/adapters/level_zero/v2/command_buffer.cpp Outdated
Comment thread source/adapters/level_zero/v2/command_list_manager.hpp Outdated
EwanC
EwanC reviewed Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR doesn't relax UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); at https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/exp_command_buffer/fixtures.h#L58 in the base CTS class, is this intentional?

igchor
igchor reviewed Jan 28, 2025
View reviewed changes
Comment thread source/adapters/level_zero/v2/queue_immediate_in_order.cpp
@lslusarczyk lslusarczyk requested a review from a team as a code owner January 28, 2025 15:40
@github-actions github-actions Bot added loader Loader related feature/bug conformance Conformance test suite issues. cuda CUDA adapter specific issues hip HIP adapter specific issues opencl OpenCL adapter specific issues labels Jan 28, 2025
@lslusarczyk
Copy link
Copy Markdown
Contributor

lslusarczyk commented Jan 28, 2025

This PR doesn't relax UUR_KNOWN_FAILURE_ON(uur::LevelZeroV2{}); at https://github.com/oneapi-src/unified-runtime/blob/main/test/conformance/exp_command_buffer/fixtures.h#L58 in the base CTS class, is this intentional?

Good point. Let's postpone enabling tests to next PRs. I'd like this PR to be merged soon, to be able to work further in parallel on v2 graphs.

@lslusarczyk
Copy link
Copy Markdown
Contributor

lslusarczyk commented Jan 28, 2025

@Bensuo , @EwanC , @igchor ,
thank you for your comments. I've applied them. Please check if I've applied them correctly. Please resolve discussions which were applied correctly or please comment these discussions which you think need more work/discussion.

@github-actions github-actions Bot added specification Changes or additions to the specification experimental Experimental feature additions/changes/specification labels Jan 28, 2025
@lslusarczyk lslusarczyk force-pushed the add-command-buffer-support branch from 311c7db to 7fc11dd Compare January 28, 2025 15:59
EwanC
EwanC approved these changes Jan 28, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@EwanC EwanC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a first stage

@pbalcer pbalcer merged commit 9a53f26 into oneapi-src:main Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@lslusarczyk lslusarczyk lslusarczyk left review comments

@nrspruit nrspruit nrspruit approved these changes

+4 more reviewers

@Bensuo Bensuo Bensuo left review comments

@kbenzie kbenzie kbenzie approved these changes

@EwanC EwanC EwanC approved these changes

@igchor igchor igchor approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

command-buffer Command Buffer feature addition/changes/specification conformance Conformance test suite issues. cuda CUDA adapter specific issues experimental Experimental feature additions/changes/specification hip HIP adapter specific issues level-zero L0 adapter specific issues loader Loader related feature/bug opencl OpenCL adapter specific issues specification Changes or additions to the specification

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@pbalcer @lslusarczyk @kbenzie @EwanC @nrspruit @Bensuo @igchor